Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Resolved conflicts in: - apps/web/app/api/generate/route.ts: Keep playgroundCatalog import - apps/web/components/playground.tsx: Use Spec type from @json-render/core
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Test generateSystemPrompt with components, actions, custom rules - Test new defineCatalog API from schema system - Test catalog.prompt() method with custom rules - Test catalog.validate() for valid and invalid specs - Test catalog.zodSchema() for custom validation - Test catalog.jsonSchema() for structured outputs - Add tests for nested specs with children - Add tests for rejecting invalid component types
Change from children={...} prop to nested children pattern
to satisfy react/no-children-prop rule.
- Disable react/prop-types in both eslint configs (TypeScript handles this) - Allow styled-jsx 'jsx' property in dashboard - Add DATABASE_URL to turbo env allowlist - Remove unused drizzle-orm imports (and, sql) - Suppress unused variable warnings where intentional
The main package entry includes React components that require client-side context (React.createContext). This causes build failures when importing in server-side API routes. Added `@json-render/remotion/server` entry point that exports only schema and catalog definitions without React dependencies: - schema, RemotionSchema, RemotionSpec - standardComponentDefinitions, standardTransitionDefinitions - standardEffectDefinitions - Type exports for catalogs Updated remotion example to import from /server in catalog.ts
The database connection threw an error at module load time if DATABASE_URL was not set, causing builds to fail in CI where the database is not available. Changed to lazy initialization using a Proxy so the error only occurs when the database is actually used at runtime, not at build time.
- Fix property name mismatch: playground now passes previousSpec instead of previousTree to match what useUIStream hook expects - Make rate limiting lazy-initialized to avoid runtime errors when Redis env vars (KV_REST_API_URL, KV_REST_API_TOKEN) are not set - Rate limiting gracefully becomes a no-op when Redis is unavailable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.